-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(ffi/unstable): Use BigInt representation in turbocall #23983
Merged
littledivy
merged 10 commits into
denoland:main
from
aapoalas:feat/ffi-breaking-turbocall-f64-representation
May 30, 2024
Merged
BREAKING(ffi/unstable): Use BigInt representation in turbocall #23983
littledivy
merged 10 commits into
denoland:main
from
aapoalas:feat/ffi-breaking-turbocall-f64-representation
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
requested review from
littledivy and
bartlomieju
and removed request for
littledivy
May 25, 2024 10:23
Performance benchmarks: This branch
deno release
|
devsnek
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit.
littledivy
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aapoalas please rebase
Will do once I get home |
aapoalas
force-pushed
the
feat/ffi-breaking-turbocall-f64-representation
branch
from
May 29, 2024 14:51
6f97eb3
to
2bf0fbb
Compare
littledivy
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built ontop of #23981 and should only be merged after it; this sets FFI turbocalls (Fast Call API) to use the BigInt representation.