Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): apply import fix to missing declaration code action #23924

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(lsp): apply import fix to missing declaration code action #23924

merged 1 commit into from
May 21, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #23916.

dsherret
dsherret approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :(

@nayeemrmn nayeemrmn merged commit cc8c060 into denoland:main May 21, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@nayeemrmn @bartlomieju
fix(lsp): apply import fix to missing declaration code action (#23924)
7f629e9
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@nayeemrmn @bartlomieju
fix(lsp): apply import fix to missing declaration code action (#23924)
4e8c1fd
@nayeemrmn nayeemrmn deleted the lsp-jsr-missing-declaration-code-action branch May 21, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP: accepting quick fix inserts import from https://jsr.io URL
2 participants
@nayeemrmn @dsherret