Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): do not panic hitting root dir while resolving npm package #23556

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(npm): do not panic hitting root dir while resolving npm package #23556

merged 1 commit into from
Apr 25, 2024

Conversation

dsherret
Copy link
Member

Closes #23029

nathanwhit
nathanwhit approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret enabled auto-merge (squash) April 25, 2024 13:47
@dsherret dsherret merged commit bc4aa5f into denoland:main Apr 25, 2024
17 checks passed
@dsherret dsherret deleted the fix_npm_no_panic_resolver branch April 29, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno has panicked in resolvers/local.rs while resolving npm package
2 participants
@dsherret @nathanwhit