Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Float16Array support #23512

Merged
merged 6 commits into from
Apr 23, 2024
Merged

fix: Float16Array support #23512

merged 6 commits into from
Apr 23, 2024

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Apr 23, 2024 •
edited
Loading

Ref #23490, #23277

  • remove --js-float16array flag (This flag has already added to deno_core)
  • add some Float16Array support

@petamoriken
Copy link
Contributor Author

@bartlomieju Please take a look when you have time!

bartlomieju
bartlomieju approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit aff7a64 into denoland:main Apr 23, 2024
17 checks passed
@petamoriken petamoriken deleted the fix/float16array branch April 23, 2024 23:29
@marvinhagemeister marvinhagemeister mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petamoriken @bartlomieju