feat: add jsx precompile skip element option #23457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Apr 20, 2024
marvinhagemeister
force-pushed
the
precompile-skip
branch
from
af91cfc
to
6718062
Compare
dsherret
reviewed
Apr 24, 2024
| @@ -213,7 +213,7 @@ async function ensureNoNewITests() { | |||
| "pm_tests.rs": 0, | |||
| "publish_tests.rs": 28, | |||
| "repl_tests.rs": 0, | |||
| "run_tests.rs": 381, | |||
| "run_tests.rs": 382, | |||
There was a problem hiding this comment.
In the future, we should be making this number go down and not up.
There was a problem hiding this comment.
I tried going the specs way but all other jsx specs used comments to set their settings. Since this has no equivalent comment (yet?) I opted to just go with the existing itest macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up a new
jsxPrecompileSkipElementsoption incompilerOptionsthat can be used to exempt a list of elements from being precompiled with theprecompileJSX transform.