feat(ext/http): Add addr to HttpServer
#23442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
addr to HttpServer [WIP]addr to HttpServer
bartlomieju
reviewed
Apr 18, 2024
cli/tsc/dts/lib.deno.ns.d.ts
Outdated
| | ServeTlsOptions | ||
| | (ServeTlsOptions & TlsCertifiedKeyOptions), | ||
| handler: ServeHandler, | ||
| ): HttpServer; | ||
| handler: ServeTlsHandler, |
There was a problem hiding this comment.
Do we need this specialized interface here? Feels to me like TLS should use ServeHandler
There was a problem hiding this comment.
We actually will need this eventually as we have to pass the TLS handshake data in. I can push this off for now but we definitely need it (soon).
There was a problem hiding this comment.
I rolled back the ServeTlsHandler for now, but left ServeTlsInit in-place.
iuioiua
reviewed
Apr 18, 2024
|
Passed:
|
mmastrac
force-pushed
the
http_server_addr
branch
from
57ad536
to
a0b4644
Compare
iuioiua
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
addrfield toHttpServerto simplify the patternDeno.serve({ onListen({ port } => listenPort = port }). This becomes:const server = Deno.serve({}); port = server.addr.port.Changes:
serveoverloads to split TLS out (in preparation for landing a place for the TLS SNI information)addrfield toHttpServerthat matches theaddrfield of the correspondingDeno.Listeners.