Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): avoid deno add and deno vendor errors when deno.json is empty #23439

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix(cli): avoid deno add and deno vendor errors when deno.json is empty #23439

merged 2 commits into from
Apr 18, 2024

Conversation

nokazn
Copy link
Contributor

@nokazn nokazn commented Apr 18, 2024 •
edited
Loading

Avoid "Failed updating config file due to no object" errors for the below commands when existing deno.json is empty. Added a test case for each.

dsherret
dsherret approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 3d841ac into denoland:main Apr 18, 2024
17 checks passed
@nokazn nokazn deleted the fix/#23215/deno-add-error branch April 18, 2024 23:32
littledivy pushed a commit to littledivy/deno that referenced this pull request Apr 19, 2024
@nokazn @littledivy
fix(cli): avoid deno add and deno vendor errors when deno.json is…
0daaf00 
… empty (denoland#23439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno add - Failed updating config file due to no object
2 participants
@nokazn @dsherret