Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/webgpu): support create UnsafeWindowSurface on Wayland #23423

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat(ext/webgpu): support create UnsafeWindowSurface on Wayland #23423

merged 1 commit into from
Apr 25, 2024

Conversation

chirsz-ever
Copy link
Contributor

This PR works fine with a simply modified deno_sdl2.

@littledivy How do you think about this?

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chirsz-ever chirsz-ever force-pushed the chirsz/byow-wayland branch from 4ed668f to 6e43b45 Compare April 18, 2024 14:33
@chirsz-ever chirsz-ever force-pushed the chirsz/byow-wayland branch from 6e43b45 to 3df7d28 Compare April 18, 2024 15:56
littledivy
littledivy approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy requested a review from crowlKats April 19, 2024 02:26
@chirsz-ever
Copy link
Contributor Author

I see some issues showing that some people try to use deno on Android and iOS. Is it necessary to support create UnsafeWindowSurface on Adnroid and iOS? Or just wait for someone who really need it?

@littledivy
Copy link
Member

I see some issues showing that some people try to use deno on Android and iOS. Is it necessary to support create UnsafeWindowSurface on Adnroid and iOS? Or just wait for someone who really need it?

If it works on Android or iOS then happy to support those options. Although, It's very hard to ensure these keep working as this feature is not tested in CI, we rely on wgpu to just work with the raw window handles.

@chirsz-ever
Copy link
Contributor Author

chirsz-ever commented Apr 20, 2024 •
edited
Loading

I am not able to test whether it would work on Android or iOS right now. But I have tested it on Wayland. So keep the status quo.

@littledivy littledivy merged commit 1de162f into denoland:main Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirsz-ever @CLAassistant @littledivy