Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTURE(ext/net): remove Deno.ConnectTlsOptions.(certFile|certChain|privateKey) #23270

Merged
merged 9 commits into from
Apr 21, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 7, 2024

Towards #23089

@iuioiua iuioiua mentioned this pull request Apr 7, 2024
10 tasks
ext/net/02_tls.js Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from bartlomieju April 9, 2024 02:11
@iuioiua
Copy link
Contributor Author

iuioiua commented Apr 9, 2024

Something is out-of-sync. These tests pass on my local machine. Fixed

@iuioiua iuioiua changed the title FUTURE(ext/net): make Deno.ConnectTlsOptions.(certFile|certChain|privateKey) illegal FUTURE(ext/net): remove Deno.ConnectTlsOptions.(certFile|certChain|privateKey) Apr 18, 2024
@bartlomieju bartlomieju added this to the 1.43 milestone Apr 19, 2024
);
const key = Deno.readTextFileSync(
new URL("../../../testdata/tls/localhost.key", import.meta.url),
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows this test to be run with cargo test or deno run.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase

@iuioiua iuioiua enabled auto-merge (squash) April 21, 2024 02:40
@iuioiua iuioiua merged commit 2f5a6a8 into denoland:main Apr 21, 2024
17 checks passed
@iuioiua iuioiua deleted the future-connecttls-options branch April 21, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants