Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): implement process.kill in Rust #23130

Merged
merged 15 commits into from
Apr 20, 2024
Merged

fix(ext/node): implement process.kill in Rust #23130

merged 15 commits into from
Apr 20, 2024

Conversation

littledivy
Copy link
Member

Closes #23056

littledivy
littledivy commented Mar 29, 2024
View reviewed changes
@littledivy littledivy marked this pull request as draft March 29, 2024 15:47
@littledivy littledivy marked this pull request as ready for review April 8, 2024 11:55
satyarohith
satyarohith approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit c0f40ed into denoland:main Apr 20, 2024
17 checks passed
@littledivy littledivy deleted the process_kill branch April 20, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maybe switch node process.kill to use rust
2 participants
@littledivy @satyarohith