Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deno.ConnectTlsOptions.{cert,key} #22274

Merged
merged 9 commits into from
Feb 18, 2024
Merged

feat: Deno.ConnectTlsOptions.{cert,key} #22274

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3fc8cd6
feat: `ConnectTlsOptions.{cert,key}`
iuioiua Feb 5, 2024
66cc22b
tweak
iuioiua Feb 5, 2024
13df2a7
tweaks
iuioiua Feb 6, 2024
44bba4d
Merge branch 'main' into connect-tls-options-key-cert
iuioiua Feb 6, 2024
b43747d
use `warnOnDeprecatedApi()`
iuioiua Feb 13, 2024
383d75d
update
iuioiua Feb 13, 2024
ac47c91
Merge branch 'main' into pr/iuioiua/22274
iuioiua Feb 13, 2024
dcc5ad9
tweaks
iuioiua Feb 13, 2024
87462e0
tweaks and fixes
iuioiua Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use warnOnDeprecatedApi()
  • Loading branch information
@iuioiua
iuioiua committed Feb 13, 2024
commit b43747de85faa879ed087b0f231e72bc4bfdf28c
16 changes: 15 additions & 1 deletion ext/net/02_tls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,21 @@ async function connectTls({
internals.warnOnDeprecatedApi(
"Deno.ConnectTlsOptions.certFile",
new Error().stack,
"Pass the cert file contents to the `Deno.ConnectTlsOptions.certChain` option instead.",
"Pass the cert file contents to the `Deno.ConnectTlsOptions.cert` option instead.",
);
}
if (certChain !== undefined) {
internals.warnOnDeprecatedApi(
"Deno.ConnectTlsOptions.certChain",
new Error().stack,
"Use the `Deno.ConnectTlsOptions.cert` option instead.",
);
}
if (privateKey !== undefined) {
internals.warnOnDeprecatedApi(
"Deno.ConnectTlsOptions.privateKey",
new Error().stack,
"Use the `Deno.ConnectTlsOptions.key` option instead.",
);
}
if (transport !== "tcp") {
Expand Down