Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): util.callbackify #22200

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jan 31, 2024

Fixes #22180

Matches the Node.js implementation more closely. Removed types, they do not help just make it harder to debug with stack traces.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking into this!

@littledivy littledivy merged commit 02c65fa into denoland:main Feb 1, 2024
15 checks passed
@littledivy littledivy deleted the rewrite_node_callbackify branch February 1, 2024 04:37
littledivy added a commit that referenced this pull request Feb 1, 2024
Fixes #22180

Matches the Node.js implementation more closely. Removed types, they do
not help just make it harder to debug with stack traces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno task build failures in node_modules/.deno/[email protected]/node_modules/fs-extra/lib/util/stat.js
4 participants