Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): fix npm module resolution when --node-modules-dir specified #17896

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix(ext/node): fix npm module resolution when --node-modules-dir specified #17896

merged 1 commit into from
Feb 23, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 23, 2023

closes #17890

@bartlomieju
Copy link
Member

LGTM, this actually closes #17448 too

@kt3k kt3k merged commit 6de8158 into denoland:main Feb 23, 2023
@kt3k kt3k deleted the fix-resolve-uses-local-node-modules branch February 23, 2023 13:28
@kt3k kt3k mentioned this pull request Feb 23, 2023
Closed
@bartlomieju bartlomieju mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cowsay errors when using a local node-modules-dir
2 participants
@kt3k @bartlomieju