Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core, runtime): Further improve startup time #17860

Merged
merged 6 commits into from
Feb 22, 2023
Merged

perf(core, runtime): Further improve startup time #17860

merged 6 commits into from
Feb 22, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Feb 21, 2023 •
edited
Loading

This commit further improves startup time by:

  • no relying on "JsRuntime::execute_script" for runtime bootstrapping,
    this is instead done using V8 APIs directly
  • registering error classes during the snapshot time, instead of on
    startup

Further improvements can be made, mainly around removing
"core.initializeAsyncOps()" which takes around 2ms.

This commit should result in ~1ms startup time improvement.

@bartlomieju bartlomieju marked this pull request as ready for review February 21, 2023 21:08
littledivy
littledivy approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit 4c6db7a into denoland:main Feb 22, 2023
@bartlomieju bartlomieju deleted the further_startup_improvement branch February 22, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @littledivy