Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webgpu): don't default to 0 for setVertexBuffer.size & properly use webidl.setlike #17800

Merged
merged 5 commits into from
Feb 23, 2023
Merged

fix(webgpu): don't default to 0 for setVertexBuffer.size & properly use webidl.setlike #17800

merged 5 commits into from
Feb 23, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Feb 16, 2023 •
edited
Loading

upstream PR: gfx-rs/wgpu#3493
Fixes #17869

bartlomieju
bartlomieju reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there some tests that we could include here?

@crowlKats crowlKats merged commit 451b45e into denoland:main Feb 23, 2023
@crowlKats crowlKats deleted the webgpu_fix branch March 17, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deno_webgpu] 'features' of GPUAdapter object is undefined
2 participants
@crowlKats @bartlomieju