perf(ext/node): move winerror binding to rust #17792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure it's that many lines? The diff doesn't show it. What's the size difference of the snapshot? |
|
@bartlomieju note the JS file got renamed to RS |
ry
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Is this PR ready?
# hyperfine --warmup 5 "/tmp/deno-pr17792 run x.js" "/tmp/deno-main run x.js" "deno run x.js"
Benchmark 1: /tmp/deno-pr17792 run x.js
Time (mean ± σ): 23.0 ms ± 0.6 ms [User: 17.1 ms, System: 3.9 ms]
Range (min … max): 22.2 ms … 25.0 ms 112 runs
Benchmark 2: /tmp/deno-main run x.js
Time (mean ± σ): 22.8 ms ± 0.5 ms [User: 18.0 ms, System: 4.1 ms]
Range (min … max): 22.1 ms … 24.5 ms 115 runs
Benchmark 3: deno run x.js (1.30.3)
Time (mean ± σ): 16.3 ms ± 0.5 ms [User: 17.7 ms, System: 4.5 ms]
Range (min … max): 15.6 ms … 18.2 ms 149 runs
|
It's a bit concerning there's no difference in startup time :/ let's push forward with other modules we listed before fully evaluating it. |
|
Fully hooked up now, and no difference in execution time :( ...maybe thats because winerror.ts is just constants that don't impact deserilazation as much. IMO Let's continue porting larger parts to Rust. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16873 lines of JS removed from the snapshot.