fix(flash): Always send correct number of bytes when handling HEAD requests #17740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not caught in the previous test case, as the response body was smaller than the size of
HEAD
response.This made
nwritten < responseLen
check inwriteFixedResponse
to fail, and not triggerop_flash_respond_async
as a result.When the response body is larger than the
HEAD
though, as in the updated test case (HEAD
i 120 bytes, where our response is 300 bytes), it would think that we still have something to send, and effectively panic, asop_flash_respond
already removed the request from the pool.This change, makes the
handleResponse
function always calculate the number of bytes to transmit whenHEAD
request is encountered. Effectively ignoringContent-Length
of the body, but still setting it correctly in the request header itself.Fixes #17737