Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate 'deno bundle' subcommand #17695

Merged
merged 3 commits into from
Feb 14, 2023
Merged

feat: Deprecate 'deno bundle' subcommand #17695

merged 3 commits into from
Feb 14, 2023

Conversation

bartlomieju
Copy link
Member

Closes #15463

@bartlomieju bartlomieju added this to the 1.31 milestone Feb 8, 2023
ry
ry reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also hide it in “deno —help” clap output?

@bartlomieju
Copy link
Member Author

@dsherret suggested that we maybe shouldn't say that it's going to be removed and require --unstable flag to use, should we ever decide that we want to revive it (and maybe replace it with some other solution). Thoughts @ry?

@bartlomieju bartlomieju merged commit 0f1349b into denoland:main Feb 14, 2023
@bartlomieju bartlomieju deleted the deprecate_deno_bundle branch February 14, 2023 01:13
@harrysolovay harrysolovay mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.

Proposal: deprecate deno bundle, add deno pack
3 participants
@bartlomieju @ry @aapoalas