Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade deno_ast to 0.23 #17269

Merged
merged 4 commits into from
Jan 4, 2023
Merged

fix: upgrade deno_ast to 0.23 #17269

merged 4 commits into from
Jan 4, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 4, 2023 •
edited
Loading

Closes #17112
Closes #15669
Closes #8529

@dsherret dsherret requested a review from bartlomieju January 4, 2023 22:33
bartlomieju
bartlomieju approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/standalone.rs Show resolved Hide resolved
@dsherret dsherret merged commit 0ee64ad into denoland:main Jan 4, 2023
@dsherret dsherret deleted the feat_upgrade_deno_ast_0_23 branch January 4, 2023 23:54
@kt3k kt3k mentioned this pull request Jan 5, 2023
Merged
@dsherret dsherret mentioned this pull request Jan 5, 2023
Closed
bartlomieju pushed a commit that referenced this pull request Jan 5, 2023
@dsherret @bartlomieju
fix: upgrade deno_ast to 0.23 (#17269)
f1ff5ed 
Closes #17172
Closes #15669
Closes #8529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno REPL allows combining && and || with ?? Deno formatter can break a switch's previously satisfied no-fallthrough linter rule Parse errors from SWC could be better
2 participants
@dsherret @bartlomieju