Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/ffi): Fast UnsafePointerView read functions #16351

Merged
merged 5 commits into from
Oct 20, 2022
Merged

feat(ext/ffi): Fast UnsafePointerView read functions #16351

merged 5 commits into from
Oct 20, 2022

Conversation

aapoalas
Copy link
Collaborator

This PR makes pointer read methods of Deno.UnsafePointerView Fast API compliant, with the exception of getCString which cannot be made fast with current V8 Fast API.

littledivy
littledivy approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit 722ea20 into denoland:main Oct 20, 2022
@aapoalas aapoalas deleted the feat/ext-ffi/fast-read-functions branch December 22, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aapoalas @littledivy