Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/flash): reregister socket on partial read on Windows #16076

Merged
merged 3 commits into from
Sep 28, 2022
Merged

fix(ext/flash): reregister socket on partial read on Windows #16076

merged 3 commits into from
Sep 28, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 28, 2022 •
edited
Loading

Alternative to #16060

Fixes #15549

Merge on approval

@bartlomieju bartlomieju mentioned this pull request Sep 28, 2022
Closed
bartlomieju
bartlomieju approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit e2828ad into denoland:main Sep 28, 2022
@bartlomieju bartlomieju deleted the fix_flash_win branch September 28, 2022 18:52
@bartlomieju bartlomieju mentioned this pull request Sep 28, 2022
Closed
@ayame113 ayame113 mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.serve hangs on Windows
2 participants
@littledivy @bartlomieju