Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): keep type args in type queries and keep empty array expr element's trailing comma #16034

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix(fmt): keep type args in type queries and keep empty array expr element's trailing comma #16034

merged 1 commit into from
Sep 26, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 26, 2022 •
edited
Loading

  • array expr - do not remove empty element's trailing comma (ex. [,,,].length === 3)
  • type arguments in type queries were accidentally being stripped

Closes #16029

@dsherret dsherret merged commit 1628dba into denoland:main Sep 26, 2022
@dsherret dsherret deleted the fix_fmt branch September 26, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter removes trailing holes from arrays
2 participants
@dsherret @cjihrig