Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(require): tryPackage uses optional chaining #16020

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix(require): tryPackage uses optional chaining #16020

merged 1 commit into from
Sep 26, 2022

Conversation

bartlomieju
Copy link
Member

I haven't been able to pin point the exact cause, but in some situations we get this error:

TypeError: Cannot read properties of null (reading 'main')
    at tryPackage (deno:ext/node/02_require.js:112:72)
    at Function.Module._findPath (deno:ext/node/02_require.js:387:20)
    at Function.Module._resolveFilename (deno:ext/node/02_require.js:598:29)
    at Function.Module._load (deno:ext/node/02_require.js:447:29)
    at Module.require (deno:ext/node/02_require.js:658:21)
    at require (deno:ext/node/02_require.js:789:18)
    at Object.<anonymous> (file:///Users/ib/dev/deno-react-vite/node_modules/.deno/@[email protected]/node_modules/@babel/core/lib/config/helpers/config-api.js:20:9)
    at Object.<anonymous> (file:///Users/ib/dev/deno-react-vite/node_modules/.deno/@[email protected]/node_modules/@babel/core/lib/config/helpers/config-api.js:110:4)
    at Module._compile (deno:ext/node/02_require.js:719:36)
    at Object.Module._extensions..js (deno:ext/node/02_require.js:752:12)

This PR changes tryPackage function in require implementation to match Node.js:
https://github.com/nodejs/node/blob/d8493c4f9752e329bffe044ada381b439b0bea37/lib/internal/modules/cjs/loader.js#L386

It makes the error go away.

@bartlomieju bartlomieju mentioned this pull request Sep 25, 2022
Closed
@bartlomieju bartlomieju merged commit 075bdfd into denoland:main Sep 26, 2022
@bartlomieju bartlomieju deleted the npm_fix_tryPackage branch September 26, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret