Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use fast ops for tty #15976

Merged
merged 12 commits into from
Sep 23, 2022
Merged

perf: use fast ops for tty #15976

merged 12 commits into from
Sep 23, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 21, 2022 •
edited
Loading

Leave no room for unnecessary overhead since consoleSize will be stabalized soon #15933

This also encourages future API changes to take fast calls into consideration.

ry
ry reviewed Sep 21, 2022
View reviewed changes
ops/lib.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/ops/tty.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Sep 22, 2022
Merged
@littledivy littledivy merged commit 72af149 into denoland:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @ry @bartlomieju