Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ext/console): avoid wrapConsole when not inspecting #15931

Merged
merged 5 commits into from
Sep 17, 2022
Merged

perf(ext/console): avoid wrapConsole when not inspecting #15931

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd804cf
perf(ext/console): avoid `wrapConsole` when not inspecting
littledivy Sep 17, 2022
ce4bfcf
fmt
littledivy Sep 17, 2022
cca99c9
Merge branch 'main' into console_perf
littledivy Sep 17, 2022
fb6496d
update test
littledivy Sep 17, 2022
d964ae0
Merge branch 'console_perf' of github.com:littledivy/deno into consol…
littledivy Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
@littledivy
littledivy committed Sep 17, 2022
commit fb6496dd4bcd44e0b5b43ef5f7357ad12334c1bc
1 change: 1 addition & 0 deletions cli/tests/testdata/event_listener_error_immediate_exit.ts.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
1
queueMicrotask
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayeemrmn @lucacasonato is this test supposed to be always deterministic? queueMicrotask is called now maybe because we don't enter v8 callconsole?

error: Uncaught Error: bar
throw new Error("bar");
^
Expand Down