-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add --compact flag for terse output #15926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please add an integration test in cli/tests/integration_tests/lint_tests.rs
that exercises --compact
flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last suggestions, otherwise I think this is good to land
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @brenelz! I think we should follow up with adding a setting to deno.json
that allows to set preferred report, something like:
{
"lint": {
"report": "compact"
}
}
Is it something you'd be willing to look into?
@bartlomieju yeah I can try and do that. Basically if you don't pass --json or --compact it would use the default from deno.json? |
Yes, exactly that! |
Related to denoland/deno_lint#1077
Added a --compact linting flag similar to the --json flag