Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm): functionality to support child_process.fork #15891

Merged
merged 9 commits into from
Sep 28, 2022
Merged

feat(npm): functionality to support child_process.fork #15891

merged 9 commits into from
Sep 28, 2022

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 13, 2022 •
edited
Loading

This adds basic functionality to support child_process.fork in deno_std. This API is considered internal.

@kt3k kt3k mentioned this pull request Sep 14, 2022
Closed
@kt3k kt3k mentioned this pull request Sep 27, 2022
Merged
@kt3k
Copy link
Member

kt3k commented Sep 27, 2022

I was able to run child_process.fork usage in prisma CLI (successfully ran deno run npm:prisma generate with this change in deno_std)

@dsherret dsherret marked this pull request as ready for review September 27, 2022 19:03
@dsherret dsherret added this to the 1.26 milestone Sep 28, 2022
bartlomieju
bartlomieju approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit d677ba6 into denoland:main Sep 28, 2022
@dsherret dsherret deleted the fork_support branch September 28, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @kt3k @bartlomieju