Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: fs optimizations - part 1 #15873

Merged
merged 24 commits into from
Sep 22, 2022
Merged

perf: fs optimizations - part 1 #15873

merged 24 commits into from
Sep 22, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 12, 2022 •
edited
Loading

  • Flatten op arguments.

    As a result, truncateSync becomes 2.3x faster.

    # main
() => truncateSync("test", 0)
time 1029 ms rate 97181
time 1013 ms rate 98716
time 745 ms rate 134228

# This patch
() => truncateSync("test", 0)
time 469 ms rate 213219
time 447 ms rate 223713

  • ~8x faster way to serialize op_stat_sync result to JS.

    # main
() => lstatSync("test")
time 767 ms rate 130378
time 767 ms rate 130378
time 745 ms rate 134228

# This patch
() => lstatSync("test")
time 99 ms rate 1010101
time 99 ms rate 1010101
time 98 ms rate 1020408

  • ~14x faster file copy on MacOS using APFS' clonefile

    # main
() => copyFileSync("test", "test2")
time 8646 ms rate 1156
time 7578 ms rate 1319

# This patch
() => copyFileSync("test", "test2")
time 738 ms rate 13550
time 647 ms rate 15455

  • Fast path for perms.read.check / perms.write.check to avoid resolve_from_cwd when possible. It's quite literally a bool check when run with -A, making it infintely faster than before.

lucacasonato
lucacasonato reviewed Sep 15, 2022
View reviewed changes
runtime/js/30_fs.js Show resolved Hide resolved
runtime/js/30_fs.js Outdated Show resolved Hide resolved
lucacasonato
lucacasonato reviewed Sep 15, 2022
View reviewed changes
runtime/ops/fs.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju reviewed Sep 17, 2022
View reviewed changes
runtime/js/30_fs.js Show resolved Hide resolved
runtime/ops/fs.rs Show resolved Hide resolved
ghost
ghost suggested changes Sep 19, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The struct writer should accept a Uint32Array -> &mut [u32]

runtime/js/30_fs.js Show resolved Hide resolved
runtime/js/30_fs.js Show resolved Hide resolved
runtime/ops/fs.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 698a340 into denoland:main Sep 22, 2022
dsherret pushed a commit to dsherret/deno that referenced this pull request Sep 22, 2022
@littledivy @dsherret
perf: fs optimizations - part 1 (denoland#15873)
14ad75f
@dragonstyle dragonstyle mentioned this pull request Dec 3, 2022
Closed
@littledivy littledivy deleted the fs_optimizations branch March 31, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas left review comments

@lucacasonato lucacasonato lucacasonato left review comments

@somebody1234 somebody1234 somebody1234 left review comments

@billywhizz billywhizz billywhizz left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@littledivy @billywhizz @somebody1234 @lucacasonato @bartlomieju @aapoalas