perf: optimize URL serialization #15663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
reviewed
Aug 29, 2022
littledivy
commented
Aug 29, 2022
7 tasks
lucacasonato
approved these changes
Sep 9, 2022
billywhizz
reviewed
Sep 9, 2022
| return core.ops.op_url_get_serialization(); | ||
| } else { | ||
| throw new TypeError("Invalid URL"); | ||
| } | ||
| } | ||
|
|
||
| class URLSearchParams { |
There was a problem hiding this comment.
i did some benchmarking and there is a small change we can make here that passes all the wpt tests and bumps perf by 15-20% when api consumer accesses searchParams getter on URL and there are no query params, which is likely the common case. i can do this in a separate PR if you like as i think there are a few other small wins we can find here.
There was a problem hiding this comment.
actually, we could just move that up to the top of the function i think?
There was a problem hiding this comment.
Nice find!
i can do this in a separate PR
yup, that'll be great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4x improvement in
(new URL(path)).pathname.