feat(runtime): web streams in fs & net APIs #13615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
requested review from
bartlomieju,
crowlKats,
kitsonk and
littledivy
as code owners
lucacasonato
force-pushed
the
web_stream_fs_and_net
branch
from
dcf4edb to
35a9474
Compare
|
+1 from me, seems very useful |
crowlKats
reviewed
Feb 7, 2022
|
Will conflict with #13660, we should land both PRs for 1.19 |
This commit adds `readable` and `writable` properties to `Deno.File` and `Deno.Conn`. This makes it very simple to use files and network sockets with fetch or the native HTTP server.
lucacasonato
force-pushed
the
web_stream_fs_and_net
branch
from
5798d1e to
c8d455e
Compare
|
LGTM 👍 |
|
Hopefully the File -> FsFile rename doesn't mess this up somehow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
readableandwritableproperties toDeno.FileandDeno.Conn. This makes it very simple to use files and network socketswith fetch or the native HTTP server.
Closes #13614