Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): op_exists handles bad specifiers #13612

Merged
merged 1 commit into from
Feb 6, 2022
Merged

fix(lsp): op_exists handles bad specifiers #13612

merged 1 commit into from
Feb 6, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Feb 6, 2022

Fixes: #13611

@kitsonk kitsonk requested a review from dsherret February 6, 2022 22:52
bartlomieju
bartlomieju approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 9c7ed1c into denoland:main Feb 6, 2022
@kitsonk kitsonk deleted the kitsonk/issue13611 branch February 6, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: chai-as-promised causing crashes
2 participants
@kitsonk @bartlomieju