Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto) - include AES-CTR in deriveKey #13174

Merged
merged 1 commit into from
Dec 27, 2021
Merged

fix(ext/crypto) - include AES-CTR in deriveKey #13174

merged 1 commit into from
Dec 27, 2021

Conversation

cryptographix
Copy link
Contributor

Towards #11690. Fix missing AES-CTR from getKeyLength(algorithm) and supportedAlgorithms.
-3K LOC in wpt.

littledivy
littledivy approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM That's a lot of tests passing!

@cryptographix cryptographix changed the title fix(crypto/deriveKey) - include AES-CTR fix(ext/crypto) - include AES-CTR in deriveKey Dec 22, 2021
ry
ry approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ry ry merged commit 07618c8 into denoland:main Dec 27, 2021
@cryptographix cryptographix deleted the derive-key-aes-ctr branch December 27, 2021 23:57
bartlomieju pushed a commit that referenced this pull request Jan 5, 2022
@cryptographix @bartlomieju
fix(ext/crypto) include AES-CTR for deriveKey (#13174)
8b9cf4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@ry ry ry approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptographix @ry @littledivy