Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stabilize URLPattern API #12256

Merged
merged 1 commit into from
Sep 29, 2021
Merged

feat: stabilize URLPattern API #12256

merged 1 commit into from
Sep 29, 2021

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Sep 28, 2021 •
edited
Loading

This stabilizes the URLPattern API introduced in Deno 1.14.

Checklist for shipping Web APIs

Also has extensive docs on MDN now: https://developer.mozilla.org/en-US/docs/Web/API/URL_Pattern_API.

@lucacasonato lucacasonato added this to the 1.15.0 milestone Sep 28, 2021
AaronO
AaronO approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju
bartlomieju approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are type declarations also stabilized?

@lucacasonato
Copy link
Member Author

LGTM, are type declarations also stabilized?

Always have been :-)

@lucacasonato lucacasonato merged commit 5b526e5 into main Sep 29, 2021
@lucacasonato lucacasonato deleted the stabilize_url_pattern branch September 29, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacasonato @AaronO @bartlomieju