Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno init --npm vite doesn't exit after "Done" until you press Enter #27129

Open
tjcrowder opened this issue Nov 28, 2024 · 1 comment · May be fixed by #27064
Open

deno init --npm vite doesn't exit after "Done" until you press Enter #27129

tjcrowder opened this issue Nov 28, 2024 · 1 comment · May be fixed by #27064

Comments

@tjcrowder
Copy link

Very minor bug: After running deno init --npm vite, the Vite scaffolding finishes and says Done, but Deno doesn't exit until you press Enter. I waited a fair bit until I thought "What if I press a key?" and happened to pick Enter. (Just Space or something doesn't work.) May be related to #26403? npm create vite exits normally. (Thanks for all the Node compat stuff in Deno! Can't be easy.)

$ deno init --log-level=debug --npm vite
⚠️ Do you fully trust npm:create-vite package? Deno will invoke code from it with all permissions. Do you want to continue? [y/n]
> y
DEBUG RS - deno::args:587 - .npmrc found at: '/home/tjc/.npmrc'
DEBUG RS - deno::args:931 - Finished config loading.
DEBUG RS - deno::cache::cache_db:170 - Opening cache /home/tjc/.cache/deno/dep_analysis_cache_v2...
DEBUG RS - deno::cache::cache_db:170 - Opening cache /home/tjc/.cache/deno/node_analysis_cache_v2...
DEBUG RS - deno::npm::managed::resolution:282 - Running npm resolution.
DEBUG RS - deno_npm::resolution::graph:932 - <package-req> - Resolved create-vite@* to [email protected]
DEBUG RS - deno::npm::managed:351 - Resolved package folder of [email protected] to /home/tjc/.cache/deno/npm/registry.npmjs.org/create-vite/6.0.1
DEBUG RS - deno::js:10 - Deno isolate init with snapshots.
DEBUG RS - deno::worker:198 - main_module file:///home/tjc/.cache/deno/npm/registry.npmjs.org/create-vite/6.0.1/index.js
? Project name: › vite-projectDEBUG RS - deno_runtime::worker:743 - received module evaluate Ok(
    (),
)
✔ Project name: … deno-vite
✔ Select a framework: › React
✔ Select a variant: › TypeScript

Scaffolding project in /home/tjc/temp/deno-vite...

Done. Now run:

  cd deno-vite
  deno install
  deno run dev

(Ignore the fact you see "Project name:" twice, that's only caused by --log-level=debug.)

deno 2.1.1 (stable, release, x86_64-unknown-linux-gnu)
v8 13.0.245.12-rusty
typescript 5.6.2
@bartlomieju
Copy link
Member

This should be fixed by #27064

@littledivy littledivy linked a pull request Nov 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node): unref pending reads in readStop littledivy/deno
2 participants
@tjcrowder @bartlomieju