Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: writableStreamDefaultControllerGetChunkSize undefined strategy case slightly broken #27102

Open
domenic opened this issue Nov 27, 2024 · 0 comments
Open

Streams: writableStreamDefaultControllerGetChunkSize undefined strategy case slightly broken #27102

domenic opened this issue Nov 27, 2024 · 0 comments
Assignees
@crowlKats
Labels
web related to Web APIs

Comments

@domenic
Copy link

domenic commented Nov 27, 2024

See whatwg/streams#1333.

Per

deno/ext/web/06_streams.js

Line 4445 in 4700f12

value = controller[_strategySizeAlgorithm](chunk);
, Deno has the same bug as the reference implementation did: it catches the exception caused by trying to call undefined as a function, and then attempts to error the stream with it.

I don't believe this is observable since the stream is already erroring so the "TypeError: cannot call undefined" will not actually be exposed to the web developer.

However, it's probably best to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowlKats crowlKats

Labels
web related to Web APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @lucacasonato @crowlKats