-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno fmt
might not respects include/exclude options in workspace settings
#26519
Comments
@dmint789 could you provide more info here? Do you have a workspace in your project? Is it open source and you could link a repo? |
I'll try to make a reproducible example soon. I do have an open source repo that could be used as an example, just need to fix a couple things first. |
@bartlomieju Okay, I have a reproducible example for both the cd client
deno task build # this will fail during linting, but that doesn't matter for this, it just has to create a `.next` directory
cd ..
deno fmt # this throws an error
deno lint # EPILEPSY WARNING! (not kidding). This gets stuck outputting garbage endlessly. But then if you uncomment the exclude property in the root |
@dmint789 I tried your repro and here's what I found:
Which is a bug in itself. Which Deno version did you use to produce it? Changing That said - there's no |
Yes, because the reproducible example is in the specific branch and commit I linked. |
Okay, thanks. I was able to reproduce it on specific commit. I created a simpler reproduction here: https://github.com/bartlomieju/deno-workspace-fmt-bug |
So I spent a few hours trying to figure out what's going wrong here and the answer is... this is working as expected at the moment. There are two problems here:
So in other words to achieve what you want, I'd suggest to add
This will only cause the I'm gonna keep this PR open for now as we will discuss if this is the behavior that should be in effect, it's quite confusing and not properly documented. |
Originally posted by @dmint789 in #26308
The text was updated successfully, but these errors were encountered: