Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter kernel sometimes panics on auto complete #26340

Closed
bartlomieju opened this issue Oct 17, 2024 · 0 comments · Fixed by #26371
Closed

Jupyter kernel sometimes panics on auto complete #26340

bartlomieju opened this issue Oct 17, 2024 · 0 comments · Fixed by #26371
Labels
bug Something isn't working correctly deno jupyter Related to "deno jupyter" subcommand

Comments

@bartlomieju
Copy link
Member

Version: Deno 2.0.0

============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.

Platform: macos aarch64
Version: 2.0.0
Args: ["/Users/~/dev/deno/target/debug/deno", "jupyter", "--kernel", "--conn", "/Users/~/L~rary/Jupyter/runtime/kernel-v3cb8e417d8c9492935ea2f74e94c46ba1c6259ca6.json"]

thread '<unnamed>' panicked at cli/tools/jupyter/server.rs:332:26:
attempt to subtract with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@bartlomieju bartlomieju added bug Something isn't working correctly deno jupyter Related to "deno jupyter" subcommand labels Oct 17, 2024
bartlomieju added a commit that referenced this issue Oct 17, 2024
I don't have a reliable reproduction for it, but it makes it
painful to use the Jupyter kernel with semi-frequent random panics.

The completions don't always work correctly anyway, so I think
it's better to just not panic here for the time being.

Fixes #26340
bartlomieju added a commit that referenced this issue Oct 17, 2024
I don't have a reliable reproduction for it, but it makes it
painful to use the Jupyter kernel with semi-frequent random panics.

The completions don't always work correctly anyway, so I think
it's better to just not panic here for the time being.

Fixes #26340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly deno jupyter Related to "deno jupyter" subcommand
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant