Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno install and deno add online help missing required specifiers #26295

Closed
kuchta opened this issue Oct 16, 2024 · 7 comments
Closed

deno install and deno add online help missing required specifiers #26295

kuchta opened this issue Oct 16, 2024 · 7 comments
Labels
needs info needs further information to be properly triaged

Comments

@kuchta
Copy link

kuchta commented Oct 16, 2024

Version: Deno 2.0.0

I suppose the specifiers haven't been required in the past, but now they are and so the examples are not correct.

@marvinhagemeister
Copy link
Contributor

What do you mean with "online help"? I've checked our documentation on docs.deno.com but wasn't able to find a case where we were the deno install command is incorrect.

Can you share the link where you found the incorrect usage?

@marvinhagemeister marvinhagemeister added the needs info needs further information to be properly triaged label Oct 16, 2024
@kuchta
Copy link
Author

kuchta commented Oct 16, 2024

It's unix terminology. Online help used to refer to built-in documentation deno <add | install> --help

: deno -h
Deno: A modern JavaScript and TypeScript runtime

Usage: deno [OPTIONS] [COMMAND]

Commands:
...
  Dependency management:
    add          Add dependencies
                  deno add @std/assert  |  deno add npm:express
...
: deno add -h
Add dependencies to your configuration file.
  deno add @std/path

You can add multiple dependencies at once:
  deno add @std/path @std/assert

Usage: deno add [OPTIONS] [packages]...

Arguments:
  [packages]...  List of packages to add

Options:
  -D, --dev    Add as a dev dependency
  -q, --quiet  Suppress diagnostic output
: deno install -h
Installs dependencies either in the local project or globally to a bin directory.

Local installation

Add dependencies to the local project's configuration (deno.json / package.json) and installs them
in the package cache. If no dependency is specified, installs all dependencies listed in the config file.
If the --entrypoint flag is passed, installs the dependencies of the specified entrypoint(s).

  deno install
  deno install @std/bytes
  deno install npm:chalk
  deno install --entrypoint entry1.ts entry2.ts
...

@marvinhagemeister
Copy link
Contributor

Gotcha, in that case this is fixed in Deno 2.0.1. You can upgrade by running deno upgrade.
PR that fixed it #26318

@kuchta
Copy link
Author

kuchta commented Oct 17, 2024

Super, looking forward 👏🏻

But unfortunately it seems like it's not available yet:

: deno upgrade                                                                                    10/17/2024 12:55:36 PM
Current Deno version: v2.0.0
Looking up stable version

Local deno version 2.0.0 is the most recent release

@marvinhagemeister
Copy link
Contributor

Yeah we pulled 2.0.1 due to a regression, see #26343 . We'll cut a new release shortly.

@kuchta
Copy link
Author

kuchta commented Oct 18, 2024

@marvinhagemeister deno -h still references @std/assert without specifier.

@marvinhagemeister
Copy link
Contributor

Thanks for pointing that out. Not sure how I missed that. Filed #26380 for it.

marvinhagemeister added a commit that referenced this issue Oct 18, 2024
Was notified of one more occurance where we were missing an explicit
specifier for a `deno add` call.

See
#26295 (comment)
bartlomieju pushed a commit that referenced this issue Oct 25, 2024
Was notified of one more occurance where we were missing an explicit
specifier for a `deno add` call.

See
#26295 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info needs further information to be properly triaged
Projects
None yet
Development

No branches or pull requests

2 participants