Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies are pulled in every time a script is edited #25968

Closed
scarf005 opened this issue Oct 1, 2024 · 1 comment · Fixed by #25969
Closed

dependencies are pulled in every time a script is edited #25968

scarf005 opened this issue Oct 1, 2024 · 1 comment · Fixed by #25969

Comments

@scarf005
Copy link
Contributor

scarf005 commented Oct 1, 2024 •
edited
Loading

2024-10-02_00-18-44.mp4

Reproduction Step

  1. repo this happenned in: https://github.com/cataclysmbnteam/Cataclysm-BN/tree/415f721646243c2cbc442194b20050d2f9437e7c (only scripts/, deno.lock, deno.jsonc and import_map.json is relevant)
  2. run deno task changelog --since "1 week ago" --until 2024-09-30
  3. edit a single character and run step 2 again
  4. packages are downloaded again
  5. running deno clean does not fix it

Version

deno 1.46.3 (stable, release, x86_64-unknown-linux-gnu)
v8 12.9.202.5-rusty
typescript 5.5.2
@scarf005 scarf005 changed the title dependencies are pulled in every time a script is ran dependencies are pulled in every time a script is edited Oct 1, 2024
@scarf005
Copy link
Contributor Author

scarf005 commented Oct 1, 2024

seems to be related to #25967 (comment),
was running deno 1.46.3 in terminal but LSP was using 2.0.0-rc

@dsherret dsherret mentioned this issue Oct 1, 2024
Merged
dsherret added a commit that referenced this issue Oct 1, 2024
@dsherret
BREAKING: rename "deps" remote cache folder to "remote" (#25969)
4c8d57d 
Closes #25967
Closes #25968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: rename "deps" remote cache folder to "remote" dsherret/deno
1 participant
@scarf005