Skip to content

FileResource-backed streams cannot be cancelled #21186

Open
@mmastrac

Description

As part of the fix for #21074, we introduced a test that started flaking. This test requires a ReadableStream to support full cancellation of all outstanding ops before the cancellation promise resolves. Unfortunately, FileResource streams do not have a any sort of read cancellation, and the op_read may last longer than the test itself.

This can likely be repro'd by opening a pipe on linux/windows and cancelling a stream when a read is outstanding.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working correctlydeno_coreChanges in "deno_core" crate are needed

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions