Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should formatter/linter ignore ignore the vendor directory? #17099

Open
lilnasy opened this issue Dec 17, 2022 · 2 comments
Open

Should formatter/linter ignore ignore the vendor directory? #17099

lilnasy opened this issue Dec 17, 2022 · 2 comments
Labels
suggestion suggestions for new features (yet to be agreed) vendor related to the vendor subcommand

Comments

@lilnasy
Copy link

lilnasy commented Dec 17, 2022

Just like node_modules, vendor contains third-party code that the formatter and linter do not need to worry about. Should it be skipped by default?

@dsherret
Copy link
Member

I'm not sure. Currently the vendor folder is not set in stone (unlike .git and node_modules) so someone could use a different folder name for the vendor folder.

FWIW, the current way to ignore it would be to do the following in a deno.json (a little verbose... it might be nice if we had a more global way to ignore folders or files):

{
  "lint": {
    "files": {
      "exclude": ["vendor/"]
    }
  },
  "fmt": {
    "files": {
      "exclude": ["vendor/"]
    }
  },
  "test": {
    "files": {
      "exclude": ["vendor/"]
    }
  },
  "bench": {
    "files": {
      "exclude": ["vendor/"]
    }
  }
}

@dsherret dsherret added suggestion suggestions for new features (yet to be agreed) vendor related to the vendor subcommand labels Dec 18, 2022
@bartlomieju
Copy link
Member

@dsherret see #15300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed) vendor related to the vendor subcommand
Projects
None yet
Development

No branches or pull requests

3 participants