Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for windows ctrl-c signal #10236

Closed
juzi5201314 opened this issue Apr 18, 2021 · 1 comment · Fixed by #14694
Closed

Support for windows ctrl-c signal #10236

juzi5201314 opened this issue Apr 18, 2021 · 1 comment · Fixed by #14694
Labels
suggestion suggestions for new features (yet to be agreed) windows Related to Windows platform

Comments

@juzi5201314
Copy link
Contributor

Hey, what I want to ask is, is there any plan to support ctrl c signal under windows?

I think this is a very useful function for the cli program. It can exit the program normally, close the resource, and trigger window.onunload.
Since tokio already has related functions, it should be very simple to implement.

This is what I simply changed: juzi5201314@9ea6d4c
@bnoordhuis bnoordhuis added suggestion suggestions for new features (yet to be agreed) windows Related to Windows platform labels Apr 19, 2021
@bnoordhuis
Copy link
Contributor

Anything that reduces the friction between Windows and UNIX is almost certainly welcome. Can you open your change as a pull request? Thanks.

@juzi5201314 juzi5201314 mentioned this issue Apr 19, 2021
Closed
4 tasks
@GJZwiers GJZwiers mentioned this issue Jun 12, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion suggestions for new features (yet to be agreed) windows Related to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(runtime/signal): implement SIGINT and SIGBREAK for windows
2 participants
@bnoordhuis @juzi5201314