Add event-emitters back

brianc · brianc · commit 76c10005670b · 2017-06-16T21:43:45.000-05:00
diff --git a/lib/client.js b/lib/client.js
@@ -374,7 +374,6 @@ Client.prototype.query = function (config, values, callback) {
     }
   } else {
     query = new Query(config, values, callback)
-    query._deprecateListeners()
     result = query
   }
 
diff --git a/lib/native/client.js b/lib/native/client.js
@@ -131,14 +131,9 @@ Client.prototype.query = function(config, values, callback) {
   }
 
   var query = new NativeQuery(config, values, callback);
-  var result = query.callback ? query : new global.Promise(function(resolve, reject) {
-    query.on('end', resolve);
-    query.on('error', reject);
-  });
-
   this._queryQueue.push(query);
   this._pulseQueryQueue();
-  return result;
+  return query;
 };
 
 //disconnect from the backend server
diff --git a/lib/native/query.js b/lib/native/query.js
@@ -67,6 +67,23 @@ NativeQuery.prototype.handleError = function(err) {
   self.state = 'error';
 };
 
+NativeQuery.prototype.then = function(onSuccess, onFailure) {
+  return this._getPromise().then(onSuccess, onFailure);
+};
+
+NativeQuery.prototype.catch = function(callback) {
+  return this._getPromise().catch(callback);
+};
+
+NativeQuery.prototype._getPromise = function() {
+  if (this._promise) return this._promise;
+  this._promise = new Promise(function(resolve, reject) {
+    this.once('end', resolve);
+    this.once('error', reject);
+  }.bind(this));
+  return this._promise;
+};
+
 NativeQuery.prototype.submit = function(client) {
   this.state = 'running';
   var self = this;
diff --git a/lib/query.js b/lib/query.js
@@ -70,9 +70,6 @@ Query.prototype._getPromise = function() {
   return this._promise;
 };
 
-Query.prototype._deprecateListeners = function() {
-}
-
 //associates row metadata from the supplied
 //message with this query object
 //metadata used when parsing row results

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,6 @@ Client.prototype.query = function (config, values, callback) {`
`374`	`374`	`}`
`375`	`375`	`} else {`
`376`	`376`	`query = new Query(config, values, callback)`
`377`		`- query._deprecateListeners()`
`378`	`377`	`result = query`
`379`	`378`	`}`
`380`	`379`