Fix warnings and KVO bug on newer Swift versions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix issue dekatotoro#34, an issue that was previously fixed by PR #73 but reappeared because of Swift-4's improved runtime checks, pointed out by Michael Brown in his blog. http://michael-brown.net/2017/swift-and-kvo-context-variables/ This buf was already fixed by PR 72, however
|
Hello, is it possible that we can merge this PR in a new Swift 4 feature branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings that appeared on newer versions of Swift and fixes bug file on issue #34