Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dsiem directive rule custom data matching #399

Merged
merged 6 commits into from
Apr 11, 2022
Merged

fix dsiem directive rule custom data matching #399

merged 6 commits into from
Apr 11, 2022

Conversation

rkspx
Copy link
Contributor

@rkspx rkspx commented Apr 11, 2022

  • fix incorrect rule matching for custom-data that contains space

@rkspx
Copy link
Contributor Author

rkspx commented Apr 11, 2022

issue reported internally

@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #399 (bfae89c) into master (cd0489d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   96.66%   96.69%   +0.03%     
==========================================
  Files          45       45              
  Lines        3177     3206      +29     
==========================================
+ Hits         3071     3100      +29     
  Misses         78       78              
  Partials       28       28
Impacted Files Coverage Δ
internal/pkg/dsiem/rule/rule.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0489d...bfae89c. Read the comment docs.

@rkspx rkspx marked this pull request as ready for review April 11, 2022 05:37
@rkspx rkspx requested a review from mmta as a code owner April 11, 2022 05:37
@rkspx rkspx merged commit 4726807 into master Apr 11, 2022
@mergify mergify bot deleted the dsiem/fix-custom-data-match branch April 11, 2022 06:15
@defenbot
Copy link

🎉 This PR is included in version 0.33.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmta mmta Awaiting requested review from mmta mmta is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkspx @defenbot