Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the PR checklist in relation to testing #907

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dbeatty10
Copy link
Contributor

resolves #906

This is a:

  • under the hood change

Problem

We have a lot of checklist items related to adding tests and running them against different warehouses. This makes it more onerous to read and complete the checklist.

Solution

Simplify the checklist by aligning more closely with the PR checklists for dbt-core, dbt-adapters, etc.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have read the contributing guide and understand what's expected of me
  • [N/A] I have run this code in development and it appears to resolve the stated issue
  • [N/A] This PR includes tests, or tests are not required/relevant for this PR
  • [N/A] I have updated the README.md (if applicable)

@dbeatty10 dbeatty10 marked this pull request as ready for review June 4, 2024 21:30
@dbeatty10 dbeatty10 merged commit df7eb81 into main Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the PR checklist in relation to testing
1 participant