Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if execute checks to xdb deprecation warnings #725

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

joellabes
Copy link
Contributor

resolves #722, resolves #720, resolves #712

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Fixes the issue where cross-db deprecation warnings are shown during project parsing, which means they come up even in macros which have migrated to the new code

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@joellabes joellabes merged commit 7c11123 into 0.9.latest Nov 22, 2022
@joellabes joellabes deleted the check-execute-before-warn branch November 22, 2022 19:06
@smitthakkar1
Copy link

Thank you for this fix. It was breaking our compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants