Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove current_timestamp macro #694

Merged
merged 19 commits into from
Oct 4, 2022
Merged

remove current_timestamp macro #694

merged 19 commits into from
Oct 4, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #693

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@colin-rogers-dbt colin-rogers-dbt changed the base branch from main to utils-v1 September 28, 2022 18:32
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review September 28, 2022 18:57
@colin-rogers-dbt colin-rogers-dbt self-assigned this Sep 28, 2022
joellabes
joellabes requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've removed an integration test unnecessarily, otherwise this looks good!

integration_tests/models/generic_tests/test_recency.sql Show resolved Hide resolved
@joellabes
Copy link
Contributor

YAY. Thanks @colin-rogers-dbt for getting this sorted!

@dbeatty10 I deleted a bunch of functional testing stuff - I'm pretty sure it is no longer needed in a utils 1.0 world but if there is anything else I should have removed too, or I shouldn't have deleted something, please let me know!

@joellabes joellabes merged commit 2a1e586 into utils-v1 Oct 4, 2022
@joellabes joellabes deleted the removeCurrentTimestamps branch October 4, 2022 05:22
@colin-rogers-dbt
Copy link
Contributor Author

thanks for getting this over the line @joellabes!

@joellabes joellabes mentioned this pull request Oct 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@joellabes joellabes Awaiting requested review from joellabes

Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated timestamp macros
4 participants
@colin-rogers-dbt @joellabes @elyobo @alexmalins