Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update union_relations to use core string literal macro #665

Merged
merged 1 commit into from
Sep 13, 2022
Merged

update union_relations to use core string literal macro #665

merged 1 commit into from
Sep 13, 2022

Conversation

dave-connors-3
Copy link
Contributor

resolves #664

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

This updates the string_literal cross db macro in union_relations to use the core version rather than the dbt_utils version to avoid deprecation warnings.

Before

image

After

image

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dbeatty10
Copy link
Contributor

@dave-connors-3 I'm guessing that CI is failing because of this, but I don't know for certain.

@dave-connors-3
Copy link
Contributor Author

@dbeatty10 have we noticed anything similar for other PRs?

@dbeatty10
Copy link
Contributor

dbeatty10 commented Sep 12, 2022 •
edited
Loading

The main branch of dbt-bigquery is broken right now:

image

Since the CI for dbt-utils uses the main branch of dbt-bigquery, I'm guessing you'll need to wait for that to be fixed before re-running the tests for this PR.

joellabes
joellabes approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes, but let's wait until BigQuery is passing to actually merge this in 👍

@dbeatty10
Copy link
Contributor

This was the PR that got things passing again.

Should be good-to-go now.

@joellabes joellabes merged commit 6de034b into main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

@dbeatty10 dbeatty10 Awaiting requested review from dbeatty10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

union_relations uses deprecated dbt_utils.string_literal()
3 participants
@dave-connors-3 @dbeatty10 @joellabes