Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dbt-spark to use batch context object instead of __dbt_internal variables #1156

Closed
Tracked by #10624
QMalcolm opened this issue Dec 11, 2024 · 1 comment
Closed
Tracked by #10624

Refactor dbt-spark to use batch context object instead of __dbt_internal variables #1156

QMalcolm opened this issue Dec 11, 2024 · 1 comment
Assignees
@QMalcolm

Comments

@QMalcolm
Copy link

QMalcolm commented Dec 11, 2024 •
edited
Loading

During the betas/rcs of dbt-core 1.9.0, the variables __dbt_internal_event_time_start and __dbt_internal_event_time_end were available on the model in the jinja context. However, when the final of dbt-core 1.9.0 was released, dbt-core started providing a batch object on the model available in the jinja context. This batch object made available all the previous information and more, and it is the "correct" way to get the information (i.e. __dbt_internal_event_time_end and __dbt_internal_event_time_start are deprecated.
@QMalcolm QMalcolm mentioned this issue Dec 11, 2024
Open
@QMalcolm QMalcolm self-assigned this Dec 11, 2024
@QMalcolm QMalcolm transferred this issue from dbt-labs/dbt-core Dec 11, 2024
@QMalcolm
Copy link
Author

dbt-spark doesn't reference the now deprecated __dbt_internal_event_time_start and __dbt_internal_event_time_end, and thus there is nothing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QMalcolm